Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 29, 2025

There was some inconsistency in parse_args where some settings were set directly and others were adding to changed_settings and thus deferred.

This change simplifies things by simply directly setting in all cases.

The two differences between direct and deferred setting are:

  • Direct settings are always overwritten by explicitly -s settings, even when the -s setting comes first, because explcit -s flags are all processed later.
  • Direct settings don't end up in the user_settings map.

I don't think either of these differences matter for the settings in question here.

There was some inconsistency in `parse_args` where some settings were
set directly and others were adding to `changed_settings` and thus
deferred.

This change simplifies things by simply directly setting in all cases.
@sbc100 sbc100 requested a review from kripken October 29, 2025 20:42
@emscripten-core emscripten-core deleted a comment from coderabbitai bot Oct 29, 2025
@sbc100 sbc100 enabled auto-merge (squash) October 29, 2025 20:51
@sbc100 sbc100 merged commit 975f97d into emscripten-core:main Oct 29, 2025
35 checks passed
@sbc100 sbc100 deleted the simpliy_arg_parse branch October 29, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants