Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some inconsistency in
parse_argswhere some settings were set directly and others were adding tochanged_settingsand thus deferred.This change simplifies things by simply directly setting in all cases.
The two differences between direct and deferred setting are:
-ssettings, even when the-ssetting comes first, because explcit-sflags are all processed later.user_settingsmap.I don't think either of these differences matter for the settings in question here.